Youtube-Code-Repository icon indicating copy to clipboard operation
Youtube-Code-Repository copied to clipboard

Little issue in ddqn_keras.py

Open jlarghi opened this issue 4 years ago • 1 comments

Hi Phil, there is a small issue in the method update_network_parameters(self), I think that should be: self.q_target.set_weights(self.q_eval.get_weights())

instead of: self.q_target.model.set_weights(self.q_eval.model.get_weights())

Thanks for your code and your videos! These are really useful for me. Jose.

jlarghi avatar Sep 27 '19 21:09 jlarghi

I have tested it, and I get a warning about Sequential.model has been deprecated. So I do not think that what you are saying is correct.

UserWarning: Sequential.model is deprecated. Sequential is a subclass of Model, you can just use your Sequential instance directly.

Gonm1 avatar Dec 13 '19 23:12 Gonm1