rustler_precompiled icon indicating copy to clipboard operation
rustler_precompiled copied to clipboard
verified publisher icon philss

Add support for headers and dynamic base URL (#65)

Open sliiser opened this issue 1 year ago • 1 comments

The :base_url attribute now accepts static headers or a custom function that returns a URL and headers. This allows us to fetch NIFs from more complicated sources, rather than just public GitHub releases.

#65

sliiser avatar Jun 25 '24 11:06 sliiser

@sliiser almost there! There is one problem in the tests, but other than that it looks great! Please take a look.

philss avatar Jul 04 '24 14:07 philss

Whoops. That test was linux only so it didn't fail on my dev machine. Fixed now (hopefully).

I also squashed the commits to be ready for merge.

sliiser avatar Jul 08 '24 10:07 sliiser

Hey, it's been a while... Anything else you need me to change here?

sliiser avatar Aug 27 '24 13:08 sliiser

@sliiser this is great! Thank you! I should release a new version today. I will ping you here.

philss avatar Aug 28 '24 15:08 philss

@sliiser it's released under v0.8.0. Please give it a try.

philss avatar Aug 29 '24 01:08 philss

Oh, sorry for not reporting back earlier. Works great! :)

sliiser avatar Oct 30 '24 15:10 sliiser