floki icon indicating copy to clipboard operation
floki copied to clipboard

Prevents Floki.Finder.find/2 from crashing

Open mellelieuwes opened this issue 1 year ago • 3 comments

See issue #604

mellelieuwes avatar Dec 10 '24 16:12 mellelieuwes

Makes sense to me. What do you think, @ypconstante ?

philss avatar Dec 10 '24 20:12 philss

BTW, thank you for the report and the fix, @mellelieuwes ! <2

philss avatar Dec 10 '24 20:12 philss

Since the function is recursive, this will probably cause us to use the expensive traversal in some cases in which we could use the fast one. I think we should handle this in the find function directly. Is this error triggered in any case besides an empty selector ""?

ypconstante avatar Dec 10 '24 20:12 ypconstante