project-bot icon indicating copy to clipboard operation
project-bot copied to clipboard

[feature request] existing review request for new PR

Open aptalca opened this issue 6 years ago • 1 comments

When a PR is opened, the new_pullrequest rules correctly adds it to the correct board. After that, if a reviewer is added, the added_reviewer rule correctly moves it to the correct board.

However, if a PR is opened with already added reviewers, the above rules don't work properly, where the new_pullrequest rule adds it to the "new PR" board but it never gets moved to the "review necessary" board because the reviewer was added before the PR was added. The added_reviewer rule never triggers.

This also happens if someone opens a new PR and within a few seconds adds a reviewer before the project-bot adds it to the project board.

I guess this request is for conditional rules. For instance, new_pullrequest could be combined with added_reviewer to add it directly to the "review necessary" board if both conditions are fulfilled. If not, it gets added to "new PR" board.

Thanks

aptalca avatar Aug 06 '19 21:08 aptalca

Just realized that this may be mitigated by #6 although that PR has been pending for over a year :(

aptalca avatar Aug 06 '19 21:08 aptalca