pobfrontend icon indicating copy to clipboard operation
pobfrontend copied to clipboard

Apply pixelRatio scaling

Open jhofmeyr opened this issue 3 years ago • 2 comments

I created a fork to try things working with the new PoB file structure. In that regard, I ended up forking PoBMacOSBuild because it automates the process a bit. The recent changes to the Community PoB file structure meant a few extra steps to get everything in the right place.

Once the front-end was loading, the scaling was off. I managed to find some info on using devicePixelRatio to rescale output for retina displays. This seems to work well for me locally, although the font size seems a little off in some areas.

I don't know any of the underlying tech (QT / OpenGL / c or lua), so I'm sure this can be greatly improved 🙏

jhofmeyr avatar Apr 08 '21 18:04 jhofmeyr

Hmm, I'm not able to test this so I'm hesitant to merge it. I see there are a couple of attempts to handle this in another fork:

https://github.com/aspel/pobfrontend/commit/f34dfe8991ee4df813c99b8b8681dbe53a8a0a45 which looks quite similar to your changes, and https://github.com/aspel/pobfrontend/commit/6f04517ee4dc49bbc18d8116573263ca7e24dbe9 reverting that and disabling hidpi?

philroberts avatar Apr 15 '21 12:04 philroberts

Hmm, I'm not able to test this so I'm hesitant to merge it. I see there are a couple of attempts to handle this in another fork:

aspel@f34dfe8 which looks quite similar to your changes, and aspel@6f04517 reverting that and disabling hidpi?

Ok - I'll try out that fork to see whether it work for me thanks :+1:

jhofmeyr avatar Apr 15 '21 15:04 jhofmeyr