FPDB-for-OSX icon indicating copy to clipboard operation
FPDB-for-OSX copied to clipboard

Published 20 hours ago • verified publisher icon philroberts

Replayer shows incorrect river card in Stud games

Open mj32 opened this issue 8 years ago • 3 comments

Using version 0.41.0-rc7 on Windows.

The river card shows up as the players first dealt card.

This can be tested using this file:

https://github.com/philroberts/FPDB-for-OSX/blob/qtfork/pyfpdb/regression-test-files/cash/Stars/Stud/7-Stud-USD-0.04-0.08-200911.txt

I'm not sure, but to fix it I think line 367 in GuiReplayer.py needs to be changed from this: if phase in ("THIRD", "FOURTH", "FIFTH", "SIXTH", "SEVENTH"):

to this: if phase in ("THIRD", "FOURTH", "FIFTH", "SIXTH", "RIVER"):

https://github.com/philroberts/FPDB-for-OSX/blob/qtfork/pyfpdb/GuiReplayer.py

Thank you guys for all the work you have done on fpdb.

mj32 avatar Oct 10 '16 19:10 mj32

Thanks for the report, I've fixed the problem locally. Hopefully my fix didn't introduce new bugs. Leaving open until I release the fixed version.

philroberts avatar Oct 11 '16 06:10 philroberts

Apparently github autoclosed this when I pushed the commit. This fix is in the release I just published.

philroberts avatar Dec 18 '16 03:12 philroberts

Oh dear, it seems my 'fix' did indeed cause problems. Going to have to take another swing at this.

philroberts avatar Dec 20 '16 20:12 philroberts