phillyphil91

Hey @ghuls I have updated the code to allow a config flag to be set on the python side for the extensive displaying of the struct. Is that what you...

Hey @ghuls any update or feedback on this? I'm not sure if the new formatting makes sense, but if we can agree on something than I could move forward with...

is this still needed @ghuls ? I saw that df.schema basically displays the struct's fields.

I wasn't sure what to do regarding the Error that `StrongSecret::from_str(s)` could produce (`Infallible`). I guess I could have also made the associative type `Err` in `FromStr` to be `type...

Hi @SanchithHegde I refactored a bigger chunk of the code when I was moving `Strategy` trait over from masking, because I realized that there would otherwise be two places for...

Hi @SanchithHegde thank you for the detailed explanation of how the masking Strategy works. It confirmed how I understood it before, but I thought maybe it's okay that `CardNumber` does...

Hi @vspecky thanks for the comment. Just to be clear, should I try to implement `Deserialize` manually for `CardNumber` according to the example that you provided?

Hey @SanchithHegde I implemented `Deserialize` for the `CardNumber` struct in a slightly different fashion than in https://github.com/juspay/hyperswitch/blob/573a4d384ee6a9d72648ab537804799a3993e1e8/crates/api_models/src/payments.rs I hope that works for you. I believe it now correctly does the...

Hi @SanchithHegde I changed all occurrences of Secret wherever it was used to hold the card number to CardNumber (there where actually quite a lot of places :smile:) A few...

hi @SanchithHegde > If it's about `unwrap()`s in tests, that's fine. If it's in production code however, you'd have to avoid it. As far as I could see, there was...