Kevin Phillips

Results 27 comments of Kevin Phillips

@BigAB so https://github.com/canjs/can-fixture/pull/129 didn't seem to work, right? Are you going to take another stab at this?

Here is the start of the conversation: https://gitter.im/donejs/donejs?at=57a0b4891c2bf6621bb598b0.

So, I started working on this and released [[email protected]](https://www.npmjs.com/package/can-define-map) and [[email protected]](https://www.npmjs.com/package/can-define-list). In doing this... a few problems came up. I'm going to detail those here so we can decide what...

`canReflect.getOwnEnumerableKeys` will give you the keys from `_define.definitions` and also any keys you pass to the constructor. There isn't a way to get all of the definitions themselves.

What would we do if both properties are the same then? If both are false, I guess it would be fine. If both are true, would you ignore the conversion...

I think I would prefer just sticking with the current properties and adding some constructors that handle throwing if passed the wrong thing ``` { Type: StrictNumber } ```

@christopherjbaker pointed out that we should take a look at https://www.npmjs.com/package/prop-types for inspiration.