pqiv icon indicating copy to clipboard operation
pqiv copied to clipboard

Image scale down broken in tiling wm since issue #129

Open pa-d-v opened this issue 4 years ago • 2 comments

I'm using tiling window manager i3. When viewing images in h-split of v-split layout they don't correctly scale down automatically and are zoomed in taking up more than available window width or height respectively. Pressing Alt-t (mod-t) or running pqiv --action="toggle_scale_mode(5)" scales it to fit the window correctly but also has the behavior of upscaling smaller images. Since correctly scaling down is more important to me than zooming I undid the commit 9f136e36005a2bb911e8b858c8e0a6ab595f34e0 made in issue #129 so images are correctly scaled down automatically again (and smaller images aren't upscaled) but no longer allows zooming in/out. Would be nice if scale down could be fixed (this issue) if possible with zooming in/out (issue #129).

Thanks in advance, Pascal

pa-d-v avatar Mar 28 '20 14:03 pa-d-v

Unfortunately, different tiling WMs have different ideas of how to interact with X11 applications. pqiv has various workarounds to create a somewhat good user experience everywhere. Maybe this changed, it's been some time since I last had a look. I don't currently have a lot of time to look into those corner cases, so I'd appreciate any help I can get (preferably in form of a PR ;))

(A simple patch could be to add an option to only conditionally apply 91f36a3 if needed?)

phillipberndt avatar Apr 11 '20 12:04 phillipberndt