pqiv icon indicating copy to clipboard operation
pqiv copied to clipboard

Allow to chain actions without intermediate images flickering on the screen

Open noctuid opened this issue 7 years ago • 5 comments
trafficstars

After updating pqiv my cycle keybindings that use send-keys (e.g. <space> { send_keys(:command); }) temporarily freeze pqiv and don't seem to do anything until subsequent keypresses (after which pqiv remains laggy).

noctuid avatar May 12 '18 07:05 noctuid

My bad. Should be fixed in latest master?!

phillipberndt avatar May 13 '18 18:05 phillipberndt

It's not freezing anymore, but my cycle keybindings aren't working as expected anymore. I have space send :cycleCN:

:cycleCN {
	set_shift_align_corner(CN);
	bind_key(h { goto_file_relative(-1\); send_keys(:cycleCS\); });
	bind_key(i { send_keys(:cycleCS\); });
}
:cycleCS {
	set_shift_align_corner(CS);
	bind_key(h { send_keys(:cycleCN\); });
	bind_key(i { goto_file_relative(1\); send_keys(:cycleCN\); });
}

I don't know if something else has changed. Hitting i for the first two times works as expected, but every subsequent press just aligns to the bottom and then immediately aligns to the top without going to the next image.

noctuid avatar May 13 '18 19:05 noctuid

Wow, that's a pretty cool improvement on your initial version of those bindings :-)

This is an unrelated bug that had been there before but was shadowed by the issue I fixed in #119. I've updated master, please give it another try.

phillipberndt avatar May 13 '18 20:05 phillipberndt

Thanks! It's working as expected now.

I don't remember this being the case before, or maybe I just noticed it now, but when going to the next image, I can see pqiv scroll the image up to the top (like a fast flicker). Is there or could there be some way to show the next image with an alignment set immediately? If this isn't simple to do, that's fine because this is a pretty minor issue.

noctuid avatar May 13 '18 22:05 noctuid

I don't remember this being the case before, or maybe I just noticed it now, but when going to the next image, I can see pqiv scroll the image up to the top (like a fast flicker). Is there or could there be some way to show the next image with an alignment set immediately? If this isn't simple to do, that's fine because this is a pretty minor issue.

I'll look into it, but don't expect anything too soon.. this'll require some rewiring regarding when actions are considered complete.

phillipberndt avatar May 15 '18 06:05 phillipberndt