terraform-aws-github-runner icon indicating copy to clipboard operation
terraform-aws-github-runner copied to clipboard

fix: move away from lambda environment variable due to size constraints

Open GuptaNavdeep1983 opened this issue 1 year ago • 2 comments

https://github.com/philips-labs/terraform-aws-github-runner/issues/3594

Renamed the variable runner_config to queues_config only for internal webhook module as there was inconsistency in naming this variable between lambda and terraform code.

I did come across this issue https://github.com/philips-labs/terraform-aws-github-runner/issues/3546 while testing this change and after adding all kms permissions(kms:*) to scale-up lambda, it started working.

Also this issue https://github.com/philips-labs/terraform-aws-github-runner/issues/3422 is also pointing at the same problem. @npalm lets synch on this issue and try to address it as I could reproduce it with multi runner example.

Update on kms issue:

After investigating further we found that the kms issue occurs if the corresponding AWS account EC2 settings is configured to use EBS with encryption.

GuptaNavdeep1983 avatar Jan 18 '24 17:01 GuptaNavdeep1983

Hey guys, any idea when this is going to be merged?

spcaipers-arm avatar Jan 30 '24 11:01 spcaipers-arm

Hey guys, any idea when this is going to be merged?

There were few comments on this PR. Addressed and tested them today. Hopefully we should be able to merge this week.

GuptaNavdeep1983 avatar Feb 07 '24 21:02 GuptaNavdeep1983