terraform-aws-github-runner
terraform-aws-github-runner copied to clipboard
philips-labs
Resource Groups are no longer working
It looks like after a change went out to update the Environment tag to ghr:environment that the Resource Group was not updated to match this.
When I navigate to the Resource Group in AWS I cannot see any related infrastructure since the tag query it is using is: Environment: prefix
If I update this to: ghr:environment: prefix
It fixes the issue.
It should be a simple fix, just need to update the resource-group.json from
{
"ResourceTypeFilters": ["AWS::AllSupported"],
"TagFilters": [
{
"Key": "Environment",
"Values": ["${environment}"]
}
]
}
to
{
"ResourceTypeFilters": ["AWS::AllSupported"],
"TagFilters": [
{
"Key": "ghr:environment",
"Values": ["${environment}"]
}
]
}
Happy to put up a PR.
We are not setting a predefined tag to all resources. Which means we cannot create a tag based resource group vai the module. Via the provider you can set a tag to all resources. This means we have to remove the resource group from the module at let it to the user to define a resource group in the deployment.
@npalm I have added a PR (#2512) to fix this if you could please review when you get a chance.