terraform-aws-github-runner icon indicating copy to clipboard operation
terraform-aws-github-runner copied to clipboard

Published 20 hours ago • verified publisher icon philips-labs

feat: Add variable to allow userdata to be passed as string to aws launch template

Open rashidnhm opened this issue 2 years ago • 15 comments

Fix for the issue mentioned in #1960. This PR enables the passing of userdata script as a string to the module.

If both variables userdata_string and userdata_template are passed, then userdata_string would take precedence.

rashidnhm avatar Apr 22 '22 22:04 rashidnhm

Note: check conflicts with #1956

npalm avatar Apr 25 '22 10:04 npalm

Note: check conflicts with #1956

Sounds good, I'll rebase my changes on top of that PR

rashidnhm avatar Apr 25 '22 13:04 rashidnhm

As this is a quite advanced usecase I think this needs an example to show a potential user how to do this and call out some of the things they need to consider along the way.

ScottGuymer avatar May 09 '22 08:05 ScottGuymer

I am also open to adding a userdata example if you'd like. Let me know.

rashidnhm avatar May 16 '22 19:05 rashidnhm

Yes, I think an example of how to use this is warranted. With some notes in the readme to guide the user when they might want to use it and what issues there could be.

ScottGuymer avatar May 17 '22 09:05 ScottGuymer

I think we are just missing the example now.

ScottGuymer avatar May 20 '22 10:05 ScottGuymer

I think we are just missing the example now.

Sounds good, currently working on getting that ready

rashidnhm avatar May 20 '22 13:05 rashidnhm

Hello, @ScottGuymer @npalm wondering if you got a chance to comb through this PR yet?

rashidnhm avatar Jun 27 '22 14:06 rashidnhm

Will put it on my list, sorry the PR got out of sight. Please can you have a look on the failing CI, some formatting is most likely the issue.

npalm avatar Jun 27 '22 20:06 npalm

@npalm Sorry about the late reply, I've fixed the formatting issue. Please take a look and let me know.

rashidnhm avatar Jul 07 '22 02:07 rashidnhm

@npalm Just checking in to see if you got a chance to comb through this?

rashidnhm avatar Jul 13 '22 15:07 rashidnhm

not yet, hope to check all the open PR's this week

npalm avatar Jul 13 '22 16:07 npalm

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 13 '22 02:08 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 13 '22 02:09 github-actions[bot]

@npalm I will try to update this PR soon and pull in all latest changes, will you have time to review anytime soon?

rashidnhm avatar Sep 14 '22 14:09 rashidnhm

@npalm the reason I had this PR is to add functionality myself for having multiple runners. However, now that #2472 is in progress, this is no longer needed on my end.

rashidnhm avatar Oct 12 '22 19:10 rashidnhm

I think in that case we should close, thanks fro reaching out

npalm avatar Oct 12 '22 19:10 npalm