terraform-aws-github-runner icon indicating copy to clipboard operation
terraform-aws-github-runner copied to clipboard

SSM parameters not cleaned up

Open samuelb opened this issue 2 years ago • 12 comments

Hello

I found today that we have hundreds of AWS System Manager Parameters defined. The lambda is creating those when starting a new runner instance to pass the authentication token and other parameters to the runner agent software.

It's so many, that aws ssm describe-parameters runs into rate limits. It's not only about keeping things clean, but also it has functional impact.

Can a cleanup of unneeded parameters get implemented?

samuelb avatar Mar 01 '22 19:03 samuelb

To clean up the parameters once, I ran

aws ssm describe-parameters --filter "Key=Name,Values=action-runner-" | jq -r ".Parameters[].Name" | xargs -n 10  aws ssm delete-parameters --names

samuelb avatar Mar 01 '22 20:03 samuelb

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar May 09 '22 08:05 github-actions[bot]

Still an issue.

tonyc-blastpoint avatar May 18 '22 15:05 tonyc-blastpoint

/remove-lifecycle stale

tonyc-blastpoint avatar May 18 '22 15:05 tonyc-blastpoint

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 18 '22 02:06 github-actions[bot]

Still an issue.

tonyc-blastpoint avatar Jun 18 '22 13:06 tonyc-blastpoint

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jul 20 '22 02:07 github-actions[bot]

Still an issue.

tonyc-blastpoint avatar Jul 20 '22 02:07 tonyc-blastpoint

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Aug 20 '22 02:08 github-actions[bot]

Still an issue.

tonyc-blastpoint avatar Aug 20 '22 22:08 tonyc-blastpoint

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 21 '22 02:09 github-actions[bot]

Still an issue!

tonyc-blastpoint avatar Sep 21 '22 12:09 tonyc-blastpoint

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Oct 23 '22 02:10 github-actions[bot]

...still an issue.

tonyc-blastpoint avatar Oct 23 '22 16:10 tonyc-blastpoint

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Nov 24 '22 02:11 github-actions[bot]

Still an issue, but a PR is on the way

samuelb avatar Nov 24 '22 08:11 samuelb

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 26 '22 01:12 github-actions[bot]

@samuelb did your PR get merged to fix this?

chasemgray avatar Jan 05 '23 23:01 chasemgray

I meant PR #2587. I'm not the author of it and no, it didn't got merged till now.

samuelb avatar Jan 06 '23 01:01 samuelb

Still an issue, but PR is closed as stale

mbeliayeu avatar Mar 03 '23 11:03 mbeliayeu

Is anyone going to reopen and merge the PR? We hit a 100,000 SSM parameter limit due to old parameters not being cleaned up.

chasemgray avatar Mar 09 '23 18:03 chasemgray