terraform-aws-github-oidc icon indicating copy to clipboard operation
terraform-aws-github-oidc copied to clipboard

Published 20 hours ago • verified publisher icon philips-labs

feat: Adding tags variable for the aws_iam_role resource

Open yiskaneto opened this issue 11 months ago • 2 comments

As we create resources is always a good practice to keep tags for them. This PR adds the tags argument to the aws_iam_role resource which reads its value from the tags variables.

Tested using Terraform and Terragrunt without any issues.

yiskaneto avatar Feb 27 '24 18:02 yiskaneto

@npalm it looks like the change I proposed was actually added as part of https://github.com/philips-labs/terraform-aws-github-oidc/releases/tag/v0.8.1, so for now I will just add some modifications to the main README.md. Please let me know if this is ok.

yiskaneto avatar Jul 20 '24 20:07 yiskaneto

@npalm it looks like the change I proposed was actually added as part of https://github.com/philips-labs/terraform-aws-github-oidc/releases/tag/v0.8.1, so for now I will just add some modifications to the main README.md. Please let me know if this is ok.

Actually I just realized the aws_iam_role resource doesn't have the tags argument, so I'm proposing the addition of such argument on this PR, I updated the docs as well and changed the title and description of the PR.

yiskaneto avatar Jul 20 '24 21:07 yiskaneto