Philipp Hofmann

Results 731 comments of Philipp Hofmann

@juraj-blahunka, we will address the issues pointed out in https://github.com/getsentry/sentry-cocoa/issues/3899#issuecomment-2077302631 because we should address them anyways. Maybe they fix your problem if not we need to investigate further.

This is related to https://github.com/getsentry/sentry-cocoa/issues/3956.

> IMO, it would be better to update the sample to point to the right place. The problem is that GH actions download the artifact into the root folder of...

@brustolin, please have a look at https://github.com/getsentry/sentry-cocoa/pull/3766#issuecomment-2007125832. I either want to merge or close this PR.

> We do currently send memory usage with all of our breadcrumbs to try to give us a better idea of where we have actual memory issues. We have that...

@armcknight, could it be that this test will become obsolete because the logic it tests will become obsolete with continuous profiling? If yes, I wouldn't fix it but delete it...

Hmm, it could be that Swift extension methods don't work. @maxchuquimia, can you try to convert the getGraphQLOperationName to a helper function that takes `URLSessionTask` as an argument and see...

> I am on board with compatibility, be we have to be able to test the platforms we claim to support. It's essential we test our code on the most...

Hey @naftaly, thanks a lot for this PR. I like the idea of subscribing to memory pressure notifications to decide if a watchdog termination was an OOM. To merge this...

> I’d love some guidance on getting this PR merged, but I can also help you folks take inspiration and go from there, I can leave it up to you...