Philipp Hofmann

Results 731 comments of Philipp Hofmann

I checked some internal SDK crashes and identified two issues that can cause crashes like this. Many crashes happen due to insufficient memory when adding breadcrumbs, either by the SDK...

The SDK should already add headers for failed HTTP requests here https://github.com/getsentry/sentry-cocoa/blob/2af280d3fd36a58915d26a619323499f72757fbc/Sources/Sentry/SentryNetworkTracker.m#L375-L379 Where exactly would you like to add custom headers? Would you like to see them as well for...

@n1tesh-airtel, can you please elaborate on why you need to add headers to these requests?

Our JavaScript SDK allows you to set custom headers with the transport options ``` Sentry.init({ transport: Sentry.makeBrowserOfflineTransport(Sentry.makeFetchTransport), transportOptions: { headers: { key: 'value' } } }) ``` The Cocoa SDK...

> but it seems like there is no way to communicate with a self-hosted Sentry server that requires custom headers using sentry-cocoa. Is this correct? @lillymaxwell, yes, sadly, that's correct.

Great catch; I also came across this recently, but I didn't create an issue. Thanks 🙏

We could identify if a crash is coming from the SDK itself by looking at the stracktrace and sending a special type event to Sentry, so we know that we...

SentryCrash has a similar concept of a recrash report, see https://github.com/getsentry/sentry-cocoa/blob/ad3b44b89858b251d3161f4a689842f1ee1772d6/Sources/SentryCrash/Recording/SentryCrashC.c#L101-L102

According to @armcknight, this is what they did for Specto: > ... we didn’t do anything like inspect a stack trace to make the determination. We simply write marker files...