Philipp Hofmann
Philipp Hofmann
Thanks, @sindresorhus for opening this issue. We put the description of the NSError into the mechanism in the SentryClient https://github.com/getsentry/sentry-cocoa/blob/cfe8e2432ed75d9986c832d401bb16d5203e8768/Sources/Sentry/SentryClient.m#L193-L195 It ends up in the JSON of the event, but...
Thanks for opening #1496 for trying to fix this issue, @lukeredpath. Unfortunately, I think we can't go forward with your PR, and we might have to close it. Here is...
Thanks, @lukeredpath, and @sindresorhus, for your input. I think we have a few problems to solve here. 1. Swift enums that conform to Error do not have a deterministic error...
> https://github.com/getsentry/sentry-cocoa/pull/1496 fixes the issue, and it implemented the suggestions in this thread, but it was ignored and autoclosed. How does Sentry expect us to interpret this? We could move...
Ups sorry, my mistake. Your PR #1496 doesn't have an impact on grouping because we group by domain and error code https://github.com/getsentry/sentry-cocoa/blob/a06565c2a78dcda8b12c677761ca83cceb136067/Sources/Sentry/SentryClient.m#L228-L232. I'm going to reopen #1496
[SentryCrashMonitor_CPPException.cpp:169](https://github.com/getsentry/sentry-cocoa/blob/master/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_CPPException.cpp#L169) is calling `g_originalTerminateHandler()`. As pointed out by you @sindresorhus, it could be that the crash monitor is crashing itself. Do you maybe have a way to reproduce this?
Thanks for the info, @sindresorhus. According to your report, it happened once. We will keep an eye on this, but without a repro, it will be hard to fix.
The original [`KSCrashMonitor_CPPException`](https://github.com/kstenerud/KSCrash/blob/master/Source/KSCrash/Recording/Monitors/KSCrashMonitor_CPPException.cpp) has a few changes our `SentryCrashMonitor_CPPException` doesn't have. I think a good start would be to include the latest fixes of KSCrash also into our SentryCrash.
Thanks for the information, @squarefrog. So you didn't see the problem before using `7.2.6`, or did you start using Sentry with `7.2.6`?
Maybe it's related to https://github.com/getsentry/sentry-cocoa/blob/d2df66ae9612bf7621bc5da788d1cc107f0ba22f/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_CPPException.cpp#L83 done in https://github.com/getsentry/sentry-cocoa/pull/1083 which was released with https://github.com/getsentry/sentry-cocoa/blob/master/CHANGELOG.md#720. Thanks for the input.