Philipp Gillé
Philipp Gillé
Sorry for the delay, replied in https://github.com/philippgille/gokv/discussions/107#discussioncomment-7921597
> @philippgille congrats on the new release! what is the decision on `Context` ? Yes, let's move forward as outlined [in the discussion](https://github.com/philippgille/gokv/discussions/107#discussioncomment-8360446). Regarding the implementation itself, I like the...
> So this PR already addresses all the implementations and looks mergeable. > Please, clarify - what is missing ? I can add whatever is needed to move this forward......
Something else came to mind: With some store configs having a timeout parameter, we should either document that they are completely ignored, _or_ in the `WithContext` methods we could check...
Sorry for the long absence, I was focused a bit on a [different project](https://github.com/philippgille/chromem-go). :bowing_man: > > Something else came to mind: With some store configs having a timeout parameter,...
Reopening manually, as it was closed automatically by merging https://github.com/philippgille/gokv/pull/139 (and description mentioned this ticket), but that was for Windows only, MacOS is in draft here: https://github.com/philippgille/gokv/pull/141
Ah great to see there's already a PR for the library. Perfect 👌
Thanks for the PR already! I don't have time to look at the code right now, maybe next week. The CI build failed because of the linter. See https://travis-ci.org/philippgille/libra-sdk-go/builds/558352696#L631 Regarding...
Great to see you're still working on it! Did you check out the TypeScript SDK I linked to in the previous comment for clues regarding the decoding? I didn't check...
> can you rebase this branch please, just would like to test/push the changes from [4341c0e](https://github.com/philippgille/chromem-go/commit/4341c0eb6a76110c3df09dac4b0b1f5568c74d0d) Oh nice! Rebased ✔️