easy-encryption icon indicating copy to clipboard operation
easy-encryption copied to clipboard

Add include guard and namespace isolation

Open v1993 opened this issue 6 years ago • 4 comments

It isn't good to fill glogal namespace, so it is better to put all function in naespace like easy_encryption.

Also, it is very important to protect headers with include guards (or #pragma once, or even better both).

v1993 avatar Jul 19 '18 08:07 v1993

Refer to this commit https://github.com/clear-m/easy-encryption/commit/b65989f2d2e05c6968d9534cc7898d6389de56ff. It in fact include all requested changes.

v1993 avatar Jul 19 '18 08:07 v1993

Could you submit a PR? :)

philipperemy avatar Jul 23 '18 01:07 philipperemy

I'll do it when will be at home, on next week. Please, don't close it yet.

v1993 avatar Jul 23 '18 07:07 v1993

Sure thanks a lot @v1993 )

philipperemy avatar Jul 23 '18 08:07 philipperemy