Philipp Spiess

Results 29 comments of Philipp Spiess

Oooh I found the right library: https://github.com/microsoft/node-jsonc-parser Of course we're already using it at Sourcegraph and of course we have contributed :D https://github.com/microsoft/node-jsonc-parser/graphs/contributors This works: ```js const fs = require("fs");...

This should do the trick, I am testing it now on https://github.com/sourcegraph/sourcegraph-search-export: ```yml name: vscode-extension-recommendation-demo description: Add a VS Code extension to the recommended extensions list # Repositories containing this...

An error happened unfortunately but Iā€™m going to continue next week. It looks like the module was not properly installed. ``` npm WARN config global `--global`, `--local` are deprecated. Use...

Check out https://github.com/philipp-spiess/use-store. It's not using `useReducer` to set up the store (maybe we can manage to add support for that?) but you can use your existing Redux-like store with...

Hey Rauno! I don't think that action creator are a big improvement given that we would need to create them in the same function where we'd use them. For React...

@sqs Yup the code looks good to me šŸ™‚

@chimon2000 Wow this is amazing! Found your PR [here](https://github.com/GantMan/ReactStateMuseum/pull/112). I'd be great to have this example inside this library as well. Thank you šŸ™Œ

I remember doing exactly that in the beginning but as you said the tests are getting very obscure with errors like this that we would need to handle: ``` Error...

My initial approach used instance methods for the reducer. You can find some comments about it in https://github.com/philipp-spiess/react-recomponent/issues/3 I agree that passing of this as the first argument to the...