Philipp Claßen
> > I have some difficulties to reproduce though. > > You should be able to reproduce by including `PRAGMA foreign_keys=ON;` > Yes, when adding that, it fails with such...
Looked at, but it is unfortunately it is hard to change the order. It is not that we generate the SQL directly; it comes indirectly by dumping an already existing...
Thanks for reporting! I think the mappings are outdated. Also, from what I can tell, all the mapped domains belong to Netflix Inc. Here is also a related discussion: https://github.com/Perflyst/PiHoleBlocklist/issues/34...
Comparing two snapshots can take a while. If it exceeds the default timeout of dbus (25 seconds in my case), the call times out. That is why the difference window...
From the discussion: for the semantic of "enablePushInjectionsOnNavigationEvents", it seems better to have it opt-out instead of opt-in. But keep the fallback. In other words, by default, the adblocker engine...
My main problem is that I still get the error with these changes in Ghostery. I used "yarn link" for all adblocker modules in common and ghostery-extension, and I see...
Also sharing here: I'm fine with merging if it improves the readability. I still think, given the semantic of the polyfill-library, the library will in any case trigger the callback:...
One aspect is here is that the HTML is not strictly valid according to the standard, so the result might depend on how the HTML parsers fix broken layouts: https://stackoverflow.com/questions/10086912/why-is-table-not-allowed-inside-p...
Github is an uncommon website, since it manages source code and often the filenames trigger false-positives in the community list (e.g. projects or filenames that include the name "ads" or...
Thanks for reporting! Will have to test if it breaks something to use `pagehide` instead of `unload`. Looking through the code, I found these places: * https://github.com/ghostery/common/blob/f1d4bcf465540c879185ba9c512291c11382bc53/modules/core/sources/content.es#L174 * https://github.com/ghostery/common/blob/f1d4bcf465540c879185ba9c512291c11382bc53/modules/core/sources/content/run.es#L103 *...