discogs-xml2db icon indicating copy to clipboard operation
discogs-xml2db copied to clipboard

Windows support

Open philipmat opened this issue 8 years ago • 4 comments

TODO for Windows support:

  • [x] get_latest_dumps - change to python and have it produce the list of URLs for wget (should not require any libraries outside the base python modules)

Downloading files with requests: https://stackoverflow.com/questions/16694907/download-large-file-in-python-with-requests

philipmat avatar Feb 24 '17 03:02 philipmat

I was thinking to something like that. Perhaps also downloading with python. Or we can stream content directly.

pfouque avatar Feb 24 '17 05:02 pfouque

@pfouque @ijabz - would you mind testing the get_dumps_xplatform branch?

I'm looking for feedback on python 2 and 3 on MacOS and Linux.

philipmat avatar Feb 24 '17 05:02 philipmat

It seems to work fine but I have some concerns about deleting actual shell file. Perhaps you should keep it ( and update it) to avoid introducing a breaking change.

pfouque avatar Feb 24 '17 10:02 pfouque

Thanks @pfouque - I really appreciate it. As far get_latest_dumps.sh, as I mentioned in my comment to your code review (thanks for it, btw!)

In the interest of keeping with the Zen of Python, I prefer that there'd be only one way of doing it. I don't want to keep two scripts when one, which is also cross-platform, is enough; it increases both confusion and maintenance.

philipmat avatar Feb 24 '17 15:02 philipmat