Philip Conrad

Results 74 comments of Philip Conrad

I'm going to add some correctness/regression tests, at the suggestion of @charlesdaniels. The tests will compare the behavior of `union(...)` against what the reference should produce. These should be cheap...

I've split the `union` tests/benchmarks off into their own files, since I'm planning to soon be doing the same process for the `intersection` builtin, and `topdown_bench_test` was getting a bit...

@tsandall @srenatus This PR should be ready for review! :smile:

@tsandall Thanks for looking the PR over! I'll merge this in soon.

After a discussion with @tsandall, I'm going to start over by trying to reuse the builtin cache, instead of doing a fully-custom, new caching system. I've backed up my previous...

There are a surprising number of panics happening in the test suite, mostly due to the NDBuiltinsCache not be initialized by default in several spots (like the WASM tests). I...

Looks like the obvious sources of Golang `panic`s have been cleared up. I'll start patching the other builtins to use the NDBuiltinCache.

Looks like the WASM SDK's e2e tests are causing issues. I'll investigate. It's probably because the WASM versions of the ND builtins aren't adding themselves to the cache. :slightly_frowning_face:

I decided to add some guard logic to the ND builtins, which take advantage of the fact that `builtins.Cache` is a pointer to a map, and in Go, pointers can...

The flaky server tests are such a pain. :upside_down_face: I'll kick the GH Actions run again once this round finishes.