better-discord-screenshare-plugin icon indicating copy to clipboard operation
better-discord-screenshare-plugin copied to clipboard

Crash Discord

Open NhProGamer opened this issue 2 years ago • 22 comments
trafficstars

This plugin totaly crash discord on load

NhProGamer avatar Mar 25 '23 08:03 NhProGamer

Okayy, the problem comes from Betterdiscord, just install it with the manual method --> https://docs.betterdiscord.app/users/getting-started/installation/#manual-installation

NhProGamer avatar Mar 25 '23 08:03 NhProGamer

I've noticed it with recent versions of Discord as well. I haven't looked that deeply into the issue because I'm trying to port the plugin and submit it to Vencord anyway. If I'm successful I'll update the repo. Thanks for the solution👍.

philhk avatar Mar 26 '23 18:03 philhk

same with me on discord stable

Cxsmo-ai avatar Apr 05 '23 21:04 Cxsmo-ai

image Discord_ZcK28NWMK3

crash when choosing screen

EndlessVoidDev avatar Apr 06 '23 04:04 EndlessVoidDev

exactly the same for me i want to use this over YABDP4Nitro but this happens good i at least have that as a backup even though this plugin way superior to YABDP4Nitro the main reason i use custom resolution and stuff is to get the best quality bitrate resolution no lag ever almost 1080p or 1080p 120fps or 63fps full screen with audio screenshare combined with obs window projector with application audio capture

Cxsmo-ai avatar Apr 06 '23 05:04 Cxsmo-ai

Hey, too bad the plugin doesn't work anymore. I made a plugin for Vencord that does exactly what this plugin does, but better. Unfortunately the plugin hasn't been merged yet, but I'm hoping that will be the case in the next few days or weeks, as the repository owner has many other PRs to check, so I'll have to wait. Here is a link to my fork. You can build it yourself with this guide and then use my plugin. I probably wont update this repository anymore.

philhk avatar Apr 06 '23 10:04 philhk

the crash still happens on the latest better discord and i want a better discord version still because there are plugins vencord does not have that stop me from switching over

Cxsmo-ai avatar Apr 08 '23 17:04 Cxsmo-ai

Hey, too bad the plugin doesn't work anymore. I made a plugin for Vencord that does exactly what this plugin does, but better. Unfortunately the plugin hasn't been merged yet, but I'm hoping that will be the case in the next few days or weeks, as the repository owner has many other PRs to check, so I'll have to wait. Here is a link to my fork. You can build it yourself with this guide and then use my plugin. I probably wont update this repository anymore.

I tried building your fork however it doesn't seem to be working i checked discord settings as well to see if the vencord section was there and it seems like it isnt injecting vencord at all

jupelost avatar Apr 13 '23 15:04 jupelost

Same for me. Same problem as jupelost.

aceyx3 avatar Apr 13 '23 16:04 aceyx3

That's weird. When you run "pnpm inject" does a new window appear? If not, can you send me the logs of the terminal.

philhk avatar Apr 13 '23 17:04 philhk

It does show the installation window after I run the pnpm inject. Though after patching, nothing appears in the settings menu.

aceyx3 avatar Apr 13 '23 17:04 aceyx3

image When you click this button do you get an error? If so you need to close Discord before clicking Install.

philhk avatar Apr 13 '23 19:04 philhk

https://user-images.githubusercontent.com/94334900/231865992-519e6443-1626-4dee-a996-ef4961b4557f.mp4

maybe im missing something?

jupelost avatar Apr 13 '23 19:04 jupelost

maybe im missing something?

Same for me.

aceyx3 avatar Apr 13 '23 19:04 aceyx3

Ok, I found the issue, it was a problem with my plugin. Just type "git pull" in the command line (if you don't have git just download the repository again) then reinstall with "pnpm inject" and it should work.

philhk avatar Apr 13 '23 19:04 philhk

Beautiful, it worked!

jupelost avatar Apr 13 '23 19:04 jupelost

Great! Thanks for helping me find the bug.

philhk avatar Apr 13 '23 20:04 philhk

Ok, I found the issue, it was a problem with my plugin. Just type "git pull" in the command line (if you don't have git just download the repository again) then reinstall with "pnpm inject" and it should work.

When should I type git pull? After I clone the repo?

aceyx3 avatar Apr 13 '23 20:04 aceyx3

You don't have to clone again, you can just use "git pull", it's updating the old version you currently have, but you can also clone the whole repo again if you want.

philhk avatar Apr 13 '23 21:04 philhk

Thank you so much! Works flawlessly, cheers!

aceyx3 avatar Apr 13 '23 21:04 aceyx3

literally doing gods work hope it becomes an official plugin soon :)!

jupelost avatar Jul 07 '23 00:07 jupelost

image Discord_ZcK28NWMK3

crash when choosing screen

Same here

LavenderAndChamomile avatar Dec 18 '23 22:12 LavenderAndChamomile