Phil Freo

Results 112 comments of Phil Freo

If there are any specific commits, possible functionality changes, etc. that you'd especially like reviewed or are unsure about, please call them out specifically.

I see that you also added a `CHANGELOG.md` in `next`. Do we want to have that in addition to http://backbonerelational.org/#change-log and keep both up to date going forward, or stick...

All of the above SGTM 👍

I assume you mean `getRelation('game').keyContents` above. So now I have to do this in many of my models so that we don't **lose data** when resaving a model that was...

While I still think #1, #2, and #3 should all pass (as discussed in #191), even just getting #1 and #2 to pass would be a big help.

@PaulUithol the 3rd of the 3 previously failing assertions above pass now, thanks to dcaf29975a2b23f85124a060526b5b5f27f11b51 (thanks!). Do you agree that the first 2 assertions should pass as well? It's super...

Generally a `collection.fetch()` won't throw that error because it will automatically reuse any model instances that exist with the same ID. I experienced some edge cases (described in #342) where...

Hi @Sundarasan - can you provide a test case showing the expected (but broken) behavior?

Hi Steven. Can you submit a test case that fails without a patch, showing your desired behavior?