tfoptflow icon indicating copy to clipboard operation
tfoptflow copied to clipboard

Published 20 hours ago • verified publisher icon philferriere

Should this be a plus sign?

Open ruizengalways opened this issue 4 years ago • 4 comments

https://github.com/philferriere/tfoptflow/blob/bdc7a72e78008d1cd6db46e4667dffc2bab1fe9e/tfoptflow/core_warp.py#L194

ruizengalways avatar Nov 25 '19 11:11 ruizengalways

@ruizengalways I also wonder about this

Superlee506 avatar Dec 10 '19 02:12 Superlee506

Is there any improvement of that~?

JunggiLee12 avatar Jan 15 '20 13:01 JunggiLee12

This has been discussed in this previous issue #6.

shuaiyuan1996 avatar Feb 26 '20 18:02 shuaiyuan1996

I believe a plus is required here. What we need is the remap image from image2. so we need + rather than a "-".

Besides, we can warp an image pair using the flow, the minus way generates bad result of alignment, but the plus one really align the images. see this comment

yaanggny avatar May 13 '22 03:05 yaanggny