philc
Regression in recent version of Brave: 'x' closes random tabs in other windows
Describe the bug
After recent Brave update (also the previous on from Jul 25), when I attempt to use 'x' to close the current tab, sometimes an unrelated tab in a different window is closed instead.
To Reproduce
Should be clear from the description above. I guess having at least three windows with at least three tabs in each would help, so one has enough tabs to try closing from different windows to be able to easily reproduce.
Browser and Vimium version
Brave | 1.80.125 Chromium: 138.0.7204.184 (Official Build) (arm64)
Revision | 79b2c43a506d75eb2978685ba92ec881f4f1e82f
OS | macOS Version 15.6 (Build 24G84)
Vimium 2.3
It is a clear regression in the browser, so I am not sure it is worth "fixing" instead of waiting it out,
that's why I don't submit a PR. But in case it will help someone, here's a fix that works around the problem for me: https://github.com/tobez/vimium/tree/fix-cross-window-tab-closure-brave - the fix involves using explicit window id for chrome.tabs.query() instead of the current { currentWindow: true } filter, and it will work equally well in those Chromiums that are not broken in this regard. If you want a proper PR, just say the word.
Since it's most likely a regression in the Brave browser, it might be worth reporting it to the developers over there if you haven't done that yet.
If there's already an existing issue on their end that is being tracked, it would be nice to have it here as a reference so people affected by it can keep track of it. That way they could see when the workaround is no longer necessary.
