vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Foreground (letter) color in labels is not black

Open andy-retailnext opened this issue 1 year ago • 3 comments

On one particular website, when using f to open a link, the letters in the yellow labels that pop up come out sort of a light gray instead of black, which makes them hard to read because of the low contrast. Website: https://www.kompoz.com Screen shot is attached. Screenshot 2024-06-16 at 6 17 31 PM

andy-retailnext avatar Jun 17 '24 01:06 andy-retailnext

That is broken because that website has a color: !important tag on the body element, which overrides the color of the link hints. This is easily fixed by changing your Vimium Options custom styles to include an !important after the color. So now that section would look like this:

div > .vimiumHintMarker span {
/* linkhint text */
color: black !important;
font-weight: bold;
font-size: 12px;
}

We might want to look into making it so that the default custom style includes the !important to avoid this issue, but I'm not sure if it's warranted. You would need to ask a maintainer if you think this should be changed.

UncleSnail avatar Jun 17 '24 18:06 UncleSnail

That worked. Thanks!

andy-retailnext avatar Jun 24 '24 00:06 andy-retailnext

If @philc doesn't think we should add the !important to the default styles, this issue can probably be closed, @andy-retailnext . I'm glad it worked!

UncleSnail avatar Jun 26 '24 14:06 UncleSnail