vimium
vimium copied to clipboard
philc
Link hints do not appear for links inside of github's popups
Describe the bug
The f shortcut (and probably the other clickable ones), doesn't work on github popups. For example, if you want to approve a pull request you could click on "Review Changes" but not on the buttons that this first one opens.
To Reproduce
You can test it on this page. On the navbar, there's a plus sign. Click it with f and it will open a popup. Then, press f again and you'll see that no option is shown.
Browser and Vimium version
Chrome: 120.0.6099.234 (Official Build) (arm64) Vimium: 2.0.5
Hey friends, I've deployed a fix on GitHub.com, this should no longer be an issue.
@keithamus that sounds awesome, thank you. Unfortunately though that is not working for me yet, despite someone in the other thread saying that it worked for them 🤔
It appears this is not a duplicate of #4369. That issue reported that clicking a Vimium link hint for the "Review changes" button did nothing. This is now fixed (thank you @keithamus!).
Instead, this issue is reporting that link hints do not show for the content inside the Review Changes popup once it's opened. This is not yet resolved. I looked into it briefly and the link hints do appear, but they appear under the popup. I didn't look further into how this is possible. Vimium's link hints should have the max z-index.
I detected this by hiding the code review popup. In the screenshot below, you can see the link hints are present if you set the popover to 0.5 opacity.
This will be because popovers are enabled on the browser you’re running (either via dom.elements.popover.enabled in about:config or by running the 122 beta I think).
The solution in this case is to make vimiums overlay also use popover.
@dudicoco https://github.com/philc/vimium/pull/4436 this starts off a fix, I can't pursue it any further but it offers the basic principles needed to get a working fix for this issue.