vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Typing "constructor " resets the search bar and creates undefined behavior.

Open sackidude opened this issue 6 months ago • 1 comments

Bug When I type constructor and then press space it completely clears the search bar. Then when delete is pressed you get "undefine" in the console, as you, presumably, deleted the "d" character. It has to be typed with nothing in front of it.

To Reproduce Steps to reproduce the behavior:

  1. Press the o-key, O-key or whatever you have bound to search in tab or new-tab.
  2. Type c-o-n-s-t-r-u-c-t-o-r-[space]
  3. Search bar gets cleared.
  4. Press [delete]-key.
  5. Shows "undefine" in searchbar.
  6. If you now for example press [enter] it searches "undefine" in the chosen search engine.

Screen recording of the bug

https://github.com/philc/vimium/assets/42474434/2c3d3aa5-9e9c-4832-8cbb-f4e474993cd2

Browser and Vimium version

Firefox version: 121.0(64-bit) Vimium version: 2.0.6 Windows version: Windows_NT 10.0 19045

sackidude avatar Dec 29 '23 17:12 sackidude

I can reproduce this. That's an awesome find =) We'll get it fixed.

On Fri, Dec 29, 2023 at 9:45 AM, NilsJR < @.*** > wrote:

Bug When I type constructor and then press space it completely clears the search bar. Then when delete is pressed you get "undefine" in the console, as you, presumably, deleted the "d" character. It has to be typed with nothing in front of it.

To Reproduce Steps to reproduce the behavior:

  • Press the o-key, O-key or whatever you have bound to search in tab or new-tab.
  • Type c-o-n-s-t-r-u-c-t-o-r-[space]
  • Search bar gets cleared.
  • Press [delete]-key.
  • Shows "undefine" in searchbar.
  • If you now for example press [enter] it searches "undefine" in the chosen search engine.

Screen recording of the bug

https:/ / github. com/ philc/ vimium/ assets/ 42474434/ 2c3d3aa5-9e9c-4832-8cbb-f4e474993cd2 ( https://github.com/philc/vimium/assets/42474434/2c3d3aa5-9e9c-4832-8cbb-f4e474993cd2 )

Browser and Vimium version

Firefox version: 121.0(64-bit) Vimium version: 2.0.6 Windows version: Windows_NT 10.0 19045

— Reply to this email directly, view it on GitHub ( https://github.com/philc/vimium/issues/4396 ) , or unsubscribe ( https://github.com/notifications/unsubscribe-auth/AAACDFUATDEF67BCMHTA6HTYL36SXAVCNFSM6AAAAABBG3VXL6VHI2DSMVQWIX3LMV43ASLTON2WKOZSGA3DAMRYG44TCMA ). You are receiving this because you are subscribed to this thread. Message ID: <philc/vimium/issues/4396 @ github. com>

philc avatar Dec 29 '23 18:12 philc