vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Restore doesn't work with large option values in 2.x version

Open componhead opened this issue 7 months ago • 5 comments

Describe the bug

Restore from a backup from 1.6.7 version doesn't works anymore in 2.0 version

To Reproduce

Steps to reproduce the behavior:

  • make a backup from 1.6.7
  • change branch to 2.0
  • restore from backup

Include a screenshot if applicable.

Browser and Vimium version

If you're using Chrome, include the Chrome and OS version found at chrome://version. Also include the Vimium version found at chrome://extensions.

Google Chrome 119.0.6045.159 (Official Build) (x86_64)
Revision eaa767197fa7dd412133d1b84f7eb60da43409c9-refs/branch-heads/6045@{#1327}
OS macOS Version 12.7.1 (Build 21G920)
JavaScript V8 11.9.169.6
User agent Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36
Command Line /Applications/Google Chrome.app/Contents/MacOS/Google Chrome --flag-switches-begin --enable-features=ImmersiveFullscreen --flag-switches-end --origin-trial-disabled-features=WebGPU
Executable Path /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

Tried using repos as plugin in chrome

componhead avatar Nov 24 '23 18:11 componhead

The reason is an axcessive size of "Custom key mappings"

componhead avatar Nov 26 '23 21:11 componhead

Ah, interesting -- can you attach a copy of your config JSON file to this bug, so I can take a look?

philc avatar Nov 28 '23 02:11 philc

Surely. If you cut from ##### SNIP ME HERE ##### it would works vimium-options-debug.json

componhead avatar Nov 28 '23 18:11 componhead

Great; I'll take a look if there's a workaround. I recall there being a storage limit per option (enforced by the browser) -- something like 4KB -- so your key mappings section may be too large. I'm not sure why this would be different between v1.67 and v2.0+.

philc avatar Nov 28 '23 18:11 philc

It's 8KB as said in https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/storage/sync

gdh1995 avatar Jan 20 '24 08:01 gdh1995