vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Real-time highlighting of the search results

Open yousfiSaad opened this issue 2 years ago • 3 comments

Description

This is an implementation of the Incremental search and highlights features. Issues talking about this feature are : https://github.com/philc/vimium/issues/3469 , https://github.com/philc/vimium/issues/591 , https://github.com/philc/vimium/issues/3100

yousfiSaad avatar Feb 15 '22 08:02 yousfiSaad

As said in https://github.com/philc/vimium/issues/3469#issuecomment-577964931, this PR creates new DOM elements to add styles to matched text, but this behavior may break some pages .

I suggest that we may use element.getBoundingClientRect() and create many <div style="left:...;top:...;width:...;height:..."> to show bounding boxes (without background color), like what Ctrl+Shift+J/K do in my Vimium C (https://github.com/gdh1995/vimium-c).

gdh1995 avatar Feb 15 '22 08:02 gdh1995

I'd love to have the feature merged into vimium 🙏

chrisgrieser avatar Apr 25 '22 21:04 chrisgrieser

As others have expressed, even if the implementation as it currently is might break in some pages, the benefits of the feature might outweigh the potential issues, what would be the harm in having this as an optional experimental feature under the advanced options with a disclamer?

MathiasSven avatar Jul 22 '22 00:07 MathiasSven