vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Published 20 hours ago • verified publisher icon philc

Fixed a minor handler-id assignment bug

Open gurjeet opened this issue 2 years ago • 2 comments

Before the fix, the anonymous name, generated for assigning to an otherwise unnamed handler, had a different value in the name than the id assigned to the handler.

This bugfix makes sure that the id used in the name of an anonymous handler matches the id assigned to the handler.

gurjeet avatar Feb 05 '22 03:02 gurjeet

@gurjeet I think this logic fix makes sense. Does the existing bug have any impact in practice?

philc avatar May 22 '22 04:05 philc

Seems no impact on UX behavior - _name is only used by console.log in HandlerStack's logResult and show.

https://github.com/philc/vimium/blob/7a9fc8d631d7ac5abc1a377194d6a46796c27898/lib/handler_stack.js#L127-L148

gdh1995 avatar May 22 '22 05:05 gdh1995

I couldn't merge this cleanly through Github's UI for some reason, so I ported these changes over in 4c0b91fd30960a9ef47035882e81d8eabaff63c8. Thanks @gurjeet

philc avatar Jul 22 '23 06:07 philc