Fullscreen breaks passNextKey
Describe the bug When using passNextKey command to enter fullscreen mode (e.g. on YouTube), fullscreen is entered, but Pass Next Key mode is not exited.
To Reproduce Steps to reproduce the behavior:
- Add
map <c-]> passNextKeymapping in the settings and save it - Go to any youtube video
- Use
<c-]> f. Fullscreen is entered, however "Pass Next Key" mode remains active and can only be exited by refreshing the page.
Note: using <c-]> t works fine entering theatre mode on YouTube, as expected, so I suspect it's the fullscreen that messes it up.
Browser and Vimium version
Google Chrome | 93.0.4577.82 (Official Build) (x86_64) OS | macOS Version 11.5.2 (Build 20G95) Vimium | 1.67
Um, I have a customized version of Vimium, named Vimium C, and it has fixed this bug since its v1.92.
The root cause is Chrome may eat keyup events: https://github.com/gdh1995/vimium-c/issues/390#issuecomment-894687506 .
This works fine on Firefox, seems to be a Chrome exclusive issue
This is an issue in Firefox as well.
@gdh1995 I’m using Vimium C version 2.12.2 from the Chrome Web Store on Brave (Chromium), and the bug is still present. When I press E (mapped to passNextKey), it enters an indefinite pass-through mode where subsequent keys keep going to the page instead of Vimium. It never exits automatically after the next key, which seems unintended behavior