vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Fullscreen breaks passNextKey

Open StanHENI opened this issue 4 years ago • 4 comments

Describe the bug When using passNextKey command to enter fullscreen mode (e.g. on YouTube), fullscreen is entered, but Pass Next Key mode is not exited.

To Reproduce Steps to reproduce the behavior:

  1. Add map <c-]> passNextKey mapping in the settings and save it
  2. Go to any youtube video
  3. Use <c-]> f. Fullscreen is entered, however "Pass Next Key" mode remains active and can only be exited by refreshing the page.

Note: using <c-]> t works fine entering theatre mode on YouTube, as expected, so I suspect it's the fullscreen that messes it up.

Browser and Vimium version

Google Chrome | 93.0.4577.82 (Official Build) (x86_64) OS | macOS Version 11.5.2 (Build 20G95) Vimium | 1.67

StanHENI avatar Sep 25 '21 09:09 StanHENI

Um, I have a customized version of Vimium, named Vimium C, and it has fixed this bug since its v1.92.

The root cause is Chrome may eat keyup events: https://github.com/gdh1995/vimium-c/issues/390#issuecomment-894687506 .

gdh1995 avatar Sep 26 '21 03:09 gdh1995

This works fine on Firefox, seems to be a Chrome exclusive issue

snprajwal avatar Oct 03 '21 06:10 snprajwal

This is an issue in Firefox as well.

slaiyer avatar Oct 13 '25 10:10 slaiyer

@gdh1995 I’m using Vimium C version 2.12.2 from the Chrome Web Store on Brave (Chromium), and the bug is still present. When I press E (mapped to passNextKey), it enters an indefinite pass-through mode where subsequent keys keep going to the page instead of Vimium. It never exits automatically after the next key, which seems unintended behavior

DePoli97 avatar Oct 16 '25 11:10 DePoli97