vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Vimium-FF can't detect alt in keymappings when resistFingerprinting is enabled

Open zingmars opened this issue 7 years ago • 6 comments

On Firefox 64.0 (64bit) on Windows 10 pressing alt+d causes vimium to perform the scrollPageDown action (instead of selecting the URL bar) even if it's bound to just d without the modifier.

zingmars avatar Dec 16 '18 11:12 zingmars

Also reproduces on the nightly builds. alt+d is one of my most used shortcuts and right now this is really annoying, for me a least.

bogdbo avatar Dec 27 '18 19:12 bogdbo

FYI, This could be caused by enabling resistFingerprinting. Disabling it allows a-d and all of the other default FF shortcuts to work for me on FF66. I have no idea why it would be connected to this setting, perhaps the idea is sites can detect which keybindings are already active to figure out which browser it is.

See #2925

hackel avatar Feb 14 '19 00:02 hackel

Thank you, disabling resistFingerprinting fixed it.

bogdbo avatar Feb 15 '19 06:02 bogdbo

this would appear an issue particularly for LibreWolf, where resistFingerprinting appears to be enabled by default. might there be a way we could fix Vimium-FF to work as expected even with this setting enabled?

KiaraGrouwstra avatar Jul 06 '22 11:07 KiaraGrouwstra

I once viewed the source code of Firefox (LibreWolf is a customized version of Firefox), and my conclusion is:

  • when resistFingerprinting is enabled, no altKey will be exposed to JavaScript web-extensions.

gdh1995 avatar Jul 06 '22 17:07 gdh1995

in that event, looking at where that puts us:

  • Alt+D was ergonomic to the fingers, but seems out under resistFingerprinting
  • Ctrl+L would still work, but seems less ergonomic

would it be viable to have an unused single key be used as a new shortcut to focus the address bar?

KiaraGrouwstra avatar Jul 06 '22 19:07 KiaraGrouwstra