vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Yank doesn't work in firefox 57.0

Open danielbaniel opened this issue 8 years ago • 28 comments

When I yank I see the vimium tooltip at the bottom - "yanked ..."

However I get nothing on my clipboard.

Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:57.0) Gecko/20100101 Firefox/57.0 Vimium: 1.61.1

danielbaniel avatar Nov 22 '17 22:11 danielbaniel

Same here on GNU/Linux version.

ghost avatar Nov 23 '17 02:11 ghost

Same here.. Firefox Quantum on linux :/

itachi-19 avatar Nov 23 '17 03:11 itachi-19

Same here. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:58.0) Gecko/20100101 Firefox/58.0 Vimium: 1.61.1

azdanov avatar Nov 28 '17 01:11 azdanov

Yank is broken on FF; a fix was merged on Saturday and will be released soon.

smblott-github avatar Nov 28 '17 05:11 smblott-github

Close?

vcunat avatar Jan 02 '18 11:01 vcunat

Hmm, actually I currently experience problems on FF with the yy command :-/ EDIT: Now it works on FF for me... I'm not sure what was wrong.

vcunat avatar Jan 02 '18 11:01 vcunat

It's also not working with Vivaldi 1.14.1036.3 + X11 (1.19.6-2) + Linux (4.14.10-1-ARCH). Similar behavior: the plugin appears to work, reports it's yanked, but does not change any of the X clipboards (primary, secondary, or clipboard).

ghost avatar Jan 06 '18 12:01 ghost

Seems to be with certain sites. For example I can't yank a specific tweet from twitter. I'm using FF 59.0.2 on Linux

neilhwatson avatar Apr 20 '18 12:04 neilhwatson

Also having this issue in FF 63.0.3 -- reports the text has been yanked, but isn't saved to the clipboard. Did anyone find a cause or fix for this?

matt-snider avatar Dec 09 '18 11:12 matt-snider

For me it's still flaky – sometimes it gets into the clipboard and sometimes doesn't; it's quite annoying for my habits. I haven't dug into causes; I've got basically no JS/... knowledge.

vcunat avatar Dec 09 '18 11:12 vcunat

Build identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:65.0) Gecko/20100101 Firefox/65.0 Vimium: 1.64.3

Issue

  • yanking the URL fails
  • the notification at the bottom of the page suggests that it succeeded (this is the real pain point, bc you think it succeeded and don't realize it has failed until you end up googling some bit of text on your clipboard 😢 )
  • failure is inconsistent

Example

here's a concrete case where vimium fails to yank the URL (yy):

  1. navigate to https://issues.apache.org/jira/projects/KAFKA/issues
  2. click on any ticket that isn't the "default" (i.e., the one in the URL)
  3. yy
  4. check whether the yanked URL matches the ticket you previously clicked on (in my case, it does not)
  5. now click on the ticket link above the title to open the ticket itself. for instance: image
  6. when the ticket opens, yy once more (in my case, it does not)
  7. click anywhere within the page and try again; now it should yank the URL correctly

i've noticed that this behavior seems to be consistent across JIRA ticketing systems. in some cases, it seems like it may be a focus problem (e.g., step 7 "fixes" the issue).

also, no idea if this is related, but yanking using link hints has also failed for me (e.g., a link in a comment on a github PR diff comment).

circld avatar Feb 11 '19 15:02 circld

I had even more bizarre behavior: after yanking current url (yy) and trying to open it in a new tab (P), I've got google page. Probably google came from empty default search engine. Then I waited for a few seconds and opened new tab again (P). I've got wrong url described by @circld in step 4.

magras avatar Feb 17 '19 14:02 magras

What I noticed is that when I yy, firefox won't react to P until the "yanked" notification label disappears.

vcunat avatar Feb 18 '19 08:02 vcunat

@magras What browser are you using? I start experiencing exactly what you describe in the latest Dev version of Chrome, I thought it was some regression on Chrome's nightly side.

innaterebel avatar Feb 18 '19 19:02 innaterebel

Well, this thread is supposedly about Firefox.

vcunat avatar Feb 18 '19 19:02 vcunat

Yes, so it surprised me a supposed Firefox user was describing exactly what I am seeing on Chrome, it may indicate Chrome is changing its clipboard API to match that of Firefox.

innaterebel avatar Feb 18 '19 20:02 innaterebel

@innaterebel, I'm using Fireforx 65.0.1 (64-bit) on different OS'es. I can reproduce behaviour described earlier only with link provided by @circld.

Also I can add to this observation that firefox will ignore all vimium keybindings, not only P. If I mouse click on a page to bring focus back while notification visible, I can P immediately.

magras avatar Feb 19 '19 01:02 magras

Thanks folks for the discussion! This is fixed in #3260, which has been released to the chrome store.

philc avatar May 12 '19 07:05 philc

This went out in v1.64.6 which is live on the Firefox store as of right now.

philc avatar May 21 '19 17:05 philc

For me is yank still broken - sometimes works and sometimes never.

Vimium: 1.64.6 FF: 67.0.4 OS: Archlinux

waldauf avatar Jul 12 '19 09:07 waldauf

I'm having this problem as well. Sometimes it'll work, sometimes it won't.

Vimium: 1.64.6 FF: 71.0 OS: Archlinux

daraul avatar Dec 29 '19 22:12 daraul

@philc @Mendess2526 https://github.com/philc/vimium/issues/2521#issuecomment-586034031 (and https://github.com/philc/vimium/issues/2677#issuecomment-503563693) has just reported the same issue, so I think PR #3277 might not fix the problem on Firefox. Then We may reopen this issue.

I may get some rest time to test it in this weekend.

gdh1995 avatar Feb 14 '20 02:02 gdh1995

Vimium 1.66, ff 68, yy doesn't work normally; it DOES work however if you click on the page and THEN press yy.

j-cr avatar Oct 26 '20 15:10 j-cr

Vimium 1.67.4 and FF 109.0 (64-bit) yanking doesn't work for me.

Frankly speaking it doesn't work for already some time, but I just decided to report it. When I press "yy" browser shows that link was "Yanked", however nothing appears in clipboard.

Is it some FF security limitation, or we have chances to fix it?

P.S.: Thanks for great plugin!!

xp-vit avatar Jan 23 '23 21:01 xp-vit

You should update, such a problem was solved relatively recently. Auto-update gave me 1.67.6 and it works for me there again.

vcunat avatar Jan 23 '23 21:01 vcunat

Is there an update available? My FF needs to provide me with any updates for my 1.67.4.

xp-vit avatar Jan 25 '23 08:01 xp-vit

i'm still experiencing this problem :\

ver 1.99.997. firefox. ubuntu 24.04 LTS

anmolmathias avatar Jul 28 '24 17:07 anmolmathias