vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Download link url command is not working

Open Mark-Eng opened this issue 8 years ago • 6 comments

The LinkHints.activateModeToDownloadLink command doesn't seem to be working on Firefox (it either does nothing or does the same as LinkHints.activateMode). Is this a case of a missing API, like the clipboard issue with FF?

Mark-Eng avatar Nov 15 '17 05:11 Mark-Eng

All LinkHints.activateModeToDownloadLink does is simulate clicking the link while holding the <Alt> key.

What happens if you manually click the link while holding the Alt key?

smblott-github avatar Nov 18 '17 12:11 smblott-github

~~It's hitting the popup blocker.~~

Edit: It hits the popup blocker if alt-click downloads is enabled (via browser.altClickSave in about:config).

mrmr1993 avatar Nov 18 '17 12:11 mrmr1993

@smblott-github, to answer your question, nothing happens when I hold alt and click the link. I get the same behavior after disabling FF's built-in pop-up blocker and my ad-blocking add-ons.

Mark-Eng avatar Nov 18 '17 12:11 Mark-Eng

I've got the same problem. I'm using Firefox 74.0 and after setting browser.altClickSave to True in about:config clicking on the link while holding Alt key works correctly. Using shortcut for LinkHints.activateModeToDownloadLink causes hints to appear but nothing happens after typing hint letters.

HunterretnuH avatar Apr 06 '20 21:04 HunterretnuH

I think this command is currently broken on all platforms anyway. Requires confirming.

A workaround is to use the newly added LinkHints.activateMode action=focus to focus a link, then Alt+Enter.

innaterebel avatar Apr 08 '20 02:04 innaterebel

The command also doesn't currently work on Chrome on Mac.

To make this work, I think we need to add a new permission, downloads. See the PR #3543.

While we can add a new permission to make this command work, it adds some UX friction (all existing users will get prompted about it during the next update) and it makes the list of permissions that Vimium requires longer still.

Given this hasn't worked for a large portion of users (all users?) in years, and only a handful of people have mentioned it (this is the only issue referencing it, I'm considering removing the command.

philc avatar Feb 13 '25 06:02 philc