vimium icon indicating copy to clipboard operation
vimium copied to clipboard

Vimium breaks escape/meta key in google sheets, despite excluding all keys for the site

Open cbetti opened this issue 8 years ago • 6 comments

Reproduction

  1. Create a rule to exclude all vimium key bindings from google sheets.
  2. Edit a spreadsheet cell.
  3. Press ESC key.

Expected Cell changes are cancelled and cell edit mode is terminated.

Actual ESC key does nothing.

Notes It seems like the ESC key is not excluded, despite an empty Exclude keys field in the rule. However, other vimium bindings are properly excluded. For example, pressing 'i' once causes a cell's contents to be replaced with the character 'i'.

Sys Info OS X on MacBook Pro Chrome Version 57.0.2987.133 (64-bit) Vimium 1.59

cbetti avatar May 16 '17 17:05 cbetti

Cell changes are cancelled and cell edit mode is terminated.

@cbetti... This (expected) behaviour is the behaviour I see; so, cannot reproduce. Moreover, looking at the code, then Vimium's keyboard handlers are (correctly) skipped if Vimium is disabled on a page.

smblott-github avatar May 17 '17 04:05 smblott-github

@cbetti Was having the same issue, but an exclude rule in the Vimium settings fixed it:

https?://docs.google.com/spreadsheets/*

rocketraman avatar May 18 '17 21:05 rocketraman

@cbetti Was having the same issue, but an exclude rule in the Vimium settings fixed it:

https?://docs.google.com/spreadsheets/*

Looks like not work for me ;/ I have this: image

But ESC still does not work (when I disable extension, ESC start work again). Can you show your exclusion, please?

shirobachi avatar Dec 03 '22 17:12 shirobachi

If Keys is empty, then Vimium should ignore all keys even including ESC and modifier keys, so you may take a try.

gdh1995 avatar Dec 07 '22 03:12 gdh1995

That's weird, but I added * since ESC did not work. I remove it and not ESC work as expected, thank you!

shirobachi avatar Dec 09 '22 19:12 shirobachi

Excluding Vimium from google spreadsheets is not an ideal solution. I still want to use some of the Vimium features when I'm on a spreadsheet (e.g., shift + t to search through open tabs).

joaocunhajeronimo avatar Feb 07 '24 12:02 joaocunhajeronimo

By adding a * in the keys to exclude section, I was able to restore the functionality of vimmum motions after pressing esc twice.

This means when I am in googlesheets whenever I want to use J or K to switch tabs, I first need to hit esc twice before it allows me to move between tabs.

I use vimmum alongside sheet keys.

Hope this helps someone.

image

jameskohjunwei avatar Jan 01 '25 05:01 jameskohjunwei

@jameskohjunwei that's helpful but it does not address the original issue:

Expected Cell changes are cancelled and cell edit mode is terminated.

Actual ESC key does nothing.

if the 'ESC' function within google spreadsheet is important for you, I'm afraid the only current solution is to disable vimium entirely on google sheets 😔

joaocunhajeronimo avatar Jan 06 '25 08:01 joaocunhajeronimo