Philip Lassen

Upstreaming Groq changes

5

We have been working with `onnx-mlir` for years now at Groq. As a result we have added some additional features, bug fixes, and have some general divergence. Time permitting could...

Fix `test/mlir/driver/buffer_loop_hoisting.mlir` lit test

1

In the latest uplift https://github.com/onnx/onnx-mlir/pull/2568 the test `test/mlir/driver/buffer_loop_hoisting.mlir` started failing. Some lit checks were deleted and the `memref.dealloc` op had to be deleted for the pass to run. As a...

Discussion on moving from `SI64` to `I64` for Attributes

1

Currently `onnx-mlir` uses `SI64Attr` for its integer attributes. However the rest of LLVM uses `I64Attr`. I suggest we migrate to `I64Attr` to stay consistent with MLIR.