git-log--graph icon indicating copy to clipboard operation
git-log--graph copied to clipboard

Blame action doesn't work in position:view

Open phil294 opened this issue 1 year ago • 5 comments

https://github.com/phil294/git-log--graph/issues/40#issuecomment-1962294235

Sorry for asking here. I'm not sure if this is an issue or if I'm not understanding it right. I noticed that the editor's context menu has a Blame: Focus last commit at cursor position in graph view option (I was wondering where it came from until I realized here that it comes from git-log-graph). It doesn't seem to do anything when I click on it. Sounds like it should activate the graph view and highlight that specific commit but it doesn't do that. I tried the command git-log--graph.blame-line, nothing reacted to it. I have set "git-log--graph.position": "view" and the view is placed in the bottom panel of the editor. The line at cursor position does have a blame. Other commands like git-log--graph.start can work but only this one doesn't work. Does it require any conditions or settings?

phil294 avatar Feb 24 '24 11:02 phil294

@Amanoki no it doesn't require anything, and since v0.1.14 (yesterday), it should also always work reliably. This looks like a bug, I'll just make a new issue out of this #77

Yes looks like it is supposed to be working but it has never worked for me since I installed the extension a couple weeks ago until now. It also doesn't work under "git-log--graph.position": "editor" My VS Code is the latest version. No other useful info to offer beyond these.

Amanoki avatar Feb 24 '24 12:02 Amanoki

same here, I didn't see any git blame feature

stunited-thien avatar Jun 29 '24 15:06 stunited-thien

Doesn't work for me either. And I would suggest to change the name of the context menu entry that one know that this belongs to GitLG. Maybe Focus last commit at cursor position in GitLG or GitLG: Focus last commit at cursor position in graph view

hansu avatar Apr 25 '25 09:04 hansu

@hansu will do.

I'll have a look at this (and the various other issues in just a few days).

phil294 avatar Apr 25 '25 10:04 phil294

No rush, just stumbled over this context menu entry and wondered where it originates from (the fact that it didn't work didn't make it easier to figure that out 😄 )

hansu avatar Apr 25 '25 11:04 hansu