git-log--graph icon indicating copy to clipboard operation
git-log--graph copied to clipboard

FEATURE: commit details

Open dimateos opened this issue 5 months ago • 4 comments

Sorry to compare, not sure how you feel about it... I just point out some details that may stop users from using your great extension.

I guess that in that regard, sadly, graph visuals are what I've seen potential new users find too weird. BUT I feel like new index-based colors are a great step + also the custom mapping is SO good!

I feel like the graph shape is less imporant than the colors, but just to mention here is the past discussion about it https://github.com/phil294/GitLG/issues/56 (issue could be renamed as "Graph design improvements" for improved search IMO)

Anyway, commits details could show more relevant info, currently shows:

  • hash
  • indices (which seem like debugging leftover, maybe cause I have "git-log--graph.verbose-logging" set to true? )
Image

For comparison, I would much appreciate some extra info

  • Author with mail (maybe committer too, but usually the same)
  • Date in local or iso (I prefer the column to be relative but the detail absolute)

So some info is already displayed in the table columns, but seems ok to also put it in the details, e.g. I can scroll looking for other commit while I can still see the selected info.

Image

Maybe it could be a configurable setting using something similar to placeholders https://github.com/phil294/GitLG/issues/126#issuecomment-3017273162

Regards!

dimateos avatar Jul 07 '25 08:07 dimateos

Some style details:

  • I wonder if it would be too hard to use the same file icons as in the currently selected icon-theme? e.g. this .bat files: Image Image
  • A vertical line separator between details and changes might be helpful
    • Btw when there is vertical overflow (as shown in the pic), shouldnt there be a bit left-side padding?
      • Very insignificant! but noticeable as there is no vertical separator in place

dimateos avatar Jul 07 '25 13:07 dimateos

I wonder if it would be too hard to use the same file icons as in the currently selected icon-theme? e.g. this .bat files:

impossible unfortunately. there was a feature request for it over at https://github.com/microsoft/vscode/issues/183893 but like most times, it was closed and muted for no reason by vscode's meme bot...

phil294 avatar Jul 08 '25 20:07 phil294

I made some approach for redesigning commit details (and branch styles #158 #159, as current does not fit in new commit details view)

What is your thoughts on this?

Commit selected Image

Two commits selected Image

Many commits selected Image

With sidebar buttons enabled Image

Commit with sidebar at the right Image

Details include committer info when there is difference with author by name or time Image

strayge avatar Aug 17 '25 13:08 strayge

@strayge this looks amazing 😍 The icons and added colors alone make a huge difference. Very much looking forward to getting this merged.

phil294 avatar Nov 01 '25 22:11 phil294