Search box only filters (no jump / highlight?)

[dimateos]

The gifs are high res, so you may open in new page etc for a better view

Can you reproduce?

---

Btw, now I dont remember how "jump" behaved. But does it also highlight matches? Because otherwise there could be a "highlight" third option? Ill recheck when this is fixed.

But some opinion in advance:

• Jump should be combined with hightlight, not a third option!
  • Like in a web browser, the text is always highlighted and it jumps when you press enter
    • It may show number of matches somewhere but not very important
  • I checked and e.g. mhutchie.git-graph does this

• This Hightlight+Jump IMO should be the default instead of filtering
  • I think this is what most users expect and filtering seems like a nice optional added feature
  • Or probably better, also remember the used by the user... now it falls back to filtering
  • Or there could be an option for it
• IDEA: given that there are only TWO options you could use a checkbox for activating the non default one (instead of radio buttons)
  • Then, following the rationale that filtering is an added feature on top of what users expect: simply show the input search box and [x] "filter" at the right

Regards!

[phil294]

Broke with recent update, I've already fixed it in the commits.

Nope, no highlighting, I think there's been an issue for that somewhere already too. But otherwise it should have worked already the way you described it.

Regarding the rest, I agree with everything you wrote! Plus it should be toggle-able by keyboard faster than now. But then again, I pretty much want everything quickly navigatable by keyboard, hate the fact that this extension is a mouse-only one.

[dimateos]

FEATURE: Would be nice to be able to highlight all when searching, maybe do it when search is set to "jump" while typing (similar to filter).

I guess I mentioned in my longo issue https://github.com/phil294/GitLG/issues/86, but I see no single issue mentioning it. Will try to strike the text and reference self-contained issues at some point!

---

I'm also all in with mouse shortcuts, mhutchie.git-graph also had an issue with that:

• it had like only 3 shorcuts
• you had to remap them in settings not the native vscode shortcuts
• the webview is the issue I guess: it was also absorbing some of the inputs?

[phil294]

implemented recently, it's now a checkbox, there's highlighting, and also more search options for file contents etc., and the selected type is remembered across restarts