git-log--graph icon indicating copy to clipboard operation
git-log--graph copied to clipboard

Resizable panel cannot be fully closed

Open dimateos opened this issue 1 year ago • 2 comments

2024-11-28_(125334)_Code

I have other extensions etc, so wondering if you are able to reproduce it!

Also just to mention it, the resizing handle is a bit awkwardly placed. Everybody expects it to be the top bar? I even thought it worked like that, because I was getting a highlight on hover... which was actually a commit in the list that you can click.


Btw, sorry for not following up with https://github.com/phil294/GitLG/issues/86 I just have an infinite backlog of stuff... Now I will leave the extension enabled for a while and see how it behaves :)

dimateos avatar Nov 28 '24 12:11 dimateos

The handle looks like that because it's reused for when the detail view is at the bottom, so I had just set it to resize: both. It was just the quickest way to do it, proper resizing logic for the entire width/height would be good and yes the bug you described is also suboptimal.

phil294 avatar Nov 29 '24 21:11 phil294

Thank you for all this input, it's super valuable!

phil294 avatar Nov 29 '24 21:11 phil294