phil-s

Results 196 comments of phil-s

After a look at some example output, I decided to give it a whirl after all, and got it working pretty well! I'm assuming that more than one space always...

Yes, non-plain-text will cause issues -- as I found when I first tried to plug in my filter, as it was acting *before* the ansi colour escape codes had been...

> But even if we could come up with a good heuristic for this, it's hard, because we're not wrapping plain text. We're wrapping formatted text, which is stored with...

> I'd figured that the "2+ spaces" heuristic might be a fragile thing to rely on, but it seems to apply in all the cases I've checked so far. Well,...

Something like `config set --require-semicolons` would be perfect, although in the interests of minimising the potential for naming conflicts, perhaps `psysh` would be a better command name than `config` ?...

> What valid PHP code do you think config set --require-semicolons might conflict with? :) My specific use case is with Drupal and the `drush core-cli` (aka `drush php`) command,...

At minimum I think the three I mentioned initially are all useful candidates: `pager`, `requireSemicolons`, `errorLoggingLevel`. I would think that anything which *can* be set at runtime would be good...

> But! PsySH currently ships with a parse command, which is disabled by default Ah, I see how that works. Perfect. > I'd happily accept a pull request adding this....

I started working on this recently, and it's turned into a bit of a rabbit hole (I will raise another issue about that), but the fundamental change works well: *...

That works perfectly, thank you. > I could see a `--format` option (or `--json` or something) to provide alternate output formats, but newlines and no decoration is a good start....