Philipp Oppermann

Results 676 comments of Philipp Oppermann

Serialization doesn't need to be changed, since the `serde::Serialize` trait gives access to the runtime value that should be serialized. So we can use the type information parsed from ROS2...

Thanks for the update! Yes, we're using this PR for the project. We need it because we precompile Python bindings on a different machine, which need to be able to...

> So the pipeline is > > byte slice → deserialize/decode → value of type `Self::Deserialized` → call [`Self::transform_deserialized`] → value of type `D` Yes, exactly! > Another question: What...

> I just created a new branch [deserialize-with-seed](https://github.com/jhelovuo/RustDDS/tree/deserialize-with-seed) for developing this feature. Please redirect the PR there. I just tried, but it looks like all the commits of this PR...

> Is there a specific reason in > > ``` > fn from_bytes_with( > input_bytes: &[u8], > encoding: RepresentationIdentifier, > decoder: S, > ) -> Result > where > S:...

What do you think about adding an `assert!(self.config.writable)` to `Shmem::as_slice_mut`?

@elast0ny Friendly ping :)

My opinion is that unit tests should be self-contained and independent of the target system. So for target-specific crates such as UEFI applications, I would move all the platform-independent stuff...

My main problem with the RAII based API is that it is not obvious where the lock is freed from a first sight. As a result, the lock is often...