blog_os icon indicating copy to clipboard operation
blog_os copied to clipboard

[Translation][Korean] post-04 (edition-2)

Open JOE1994 opened this issue 2 years ago • 1 comments

JOE1994 avatar Aug 28 '22 00:08 JOE1994

Hello @Quqqu, would you be available to review the Korean translation?

JOE1994 avatar Aug 28 '22 01:08 JOE1994

Hi @JOE1994, thanks a lot for the PR and sorry for the delay in reviewing. I try my best to find someone to review as soon as possible!

If someone who speaks Korean is reading this: It would be great if you could give this PR a quick review so that we can merge it!

phil-opp avatar Oct 02 '22 15:10 phil-opp

Can I do a review?

ghost avatar Oct 16 '22 05:10 ghost

This proposal is a readability proposal. Read and reflect only what you need. :)

liquidsaul avatar Oct 17 '22 04:10 liquidsaul

This proposal is a readability proposal. Read and reflect only what you need. :)

ghost avatar Oct 17 '22 04:10 ghost

@SNOOPYOF Thank you so much for reviewing this PR! I've pushed a commit that applies your suggested changes.

If the current result looks good to you, I'll squash the commits into a single commit, add you as a co-author to the commit, and add your github id to the translators' list of this post :+1:

JOE1994 avatar Oct 17 '22 05:10 JOE1994

Can I review this PR?

dalinaum avatar Oct 17 '22 09:10 dalinaum

I read all suggestions from @dalinaum , and pushed another commit to apply the suggestions. Thanks for all the comments! I've just finished reviewing the rendered page, and it looks all right to me. I'll force-push a squashed commit soon.

JOE1994 avatar Oct 18 '22 15:10 JOE1994

@phil-opp I think this PR is now ready for your review. Thank you!

JOE1994 avatar Oct 18 '22 15:10 JOE1994

Thanks a lot for translating @JOE1994 and thanks to @SNOOPYOF and @dalinaum for reviewing!

phil-opp avatar Oct 18 '22 15:10 phil-opp

Published at https://os.phil-opp.com/ko/testing/.

phil-opp avatar Oct 18 '22 16:10 phil-opp