Phil Léger

Results 68 comments of Phil Léger

No worries, if you think this is relevant, let's leave the issue open, otherwise, it can be closed, since the plugin doesn't tap into Symbols' Overrides for now

Sorry to pollute this thread and the ironic tone, but ... IMO Sanity in 2022 should have 100% TypeScript support, hell, all the init/sample projects should be scaffolded in TS...

Same thing for enums: ```ts const palette = { [ENUM.NAME1]: colors.red, "ui-1": colors.blue } ``` Does not work either

If one of you @roperzh @zackbrown can point me out where to start looking, I’d be happy to try and add a test case Also I’d want to know why...

In https://github.com/diez/diez/blob/master/src/framework/engine/test/prefab.test.ts#L22 I extended the test to include a nested prop: ```ts class FooPrefab extends prefab() { defaults = { justbar: ['bar'], foobar: new FooString(), nested: { foobar: new FooString({...

Just pasting this for documentation purposes Rob's overview of what diez does - It compiles the source TypeScript code to JavaScript: https://github.com/diez/diez/blob/220f76cd06c265e82e6da3adfe04bd744923e9b3/src/compiler/compiler-core/src/parser.ts#L545 - Requires the compiled design system: https://github.com/diez/diez/blob/220f76cd06c265e82e6da3adfe04bd744923e9b3/src/compiler/compiler-core/src/compiler.ts#L295-L300 -...

So I've added: ![image](https://user-images.githubusercontent.com/9644867/88562905-4a658a00-cfff-11ea-99c1-dbcf4937efeb.png) In the Primitives.ts When when I debug in the parser, I think we have a problem in this area: ![image](https://user-images.githubusercontent.com/9644867/88562971-610be100-cfff-11ea-81d9-c8550d602dd6.png) Looks like we don't get the...

so at this point: ![image](https://user-images.githubusercontent.com/9644867/88563701-471ece00-d000-11ea-95fc-fb41addb1a4e.png) it looks like the parser supports class declaration or variable declaration but not object litteral?

![image](https://user-images.githubusercontent.com/9644867/88565258-51da6280-d002-11ea-85a3-addf282fc4c0.png) In this case, `nested` is a PropertyAssignment: ![image](https://user-images.githubusercontent.com/9644867/88565374-80583d80-d002-11ea-8c50-5c8865522f71.png) Ok, and it looks like we don't handle Properties assignment here as well: ![image](https://user-images.githubusercontent.com/9644867/88565626-dfb64d80-d002-11ea-843a-46135bbc46a5.png) I think I understand what's is going...

Added other tests cases which outlines other bugs: ```ts const colorBlack = Color.hex('#000'); const colorRed = Color.hex('#CE0000'); const nestedPrefabComponent = new NestedPrefabComponent({ child, diez: 1, color: colorBlack, }); const nestedPrefabComponentWithRedColor...