has.js icon indicating copy to clipboard operation
has.js copied to clipboard

Published 20 hours ago • verified publisher icon phiggins42

Update has.js

Open AndrewEastwood opened this issue 11 years ago • 15 comments

Adding requirejs config support

AndrewEastwood avatar Jun 03 '14 13:06 AndrewEastwood

ok, I removed third '='

AndrewEastwood avatar Jun 05 '14 20:06 AndrewEastwood

:smile: what about now?

AndrewEastwood avatar Jun 05 '14 20:06 AndrewEastwood

Can you add a unit test and have you signed the CLA?

jdalton avatar Jun 05 '14 20:06 jdalton

alright. I've signed it just now :grinning:

AndrewEastwood avatar Jun 05 '14 21:06 AndrewEastwood

CLA submitted on 2014-06-05 21:06:04.

jdalton avatar Jun 05 '14 21:06 jdalton

So for the test it looks like runTests.html has require.js commented out. Maybe enable it below the other script loads, load it via AMD+config, & delay the population of the results until after the module is loaded. Whew.

jdalton avatar Jun 05 '14 21:06 jdalton

omg! the version of requirejs is 0.14.5+ I'm gonna upgrade it to 2.1.14

AndrewEastwood avatar Jun 05 '14 21:06 AndrewEastwood

+1

fn-zz avatar Jun 06 '14 00:06 fn-zz

I come up with that approach for tests or, we can rewrite all detects to use requirejs (:

AndrewEastwood avatar Jun 06 '14 09:06 AndrewEastwood

I'll try to review this soon but can't make any promises :disappointed:

jdalton avatar Jun 11 '14 16:06 jdalton

This waits whole month for review :unamused:

AndrewEastwood avatar Jul 09 '14 13:07 AndrewEastwood

Sorry, I haven't made time for this yet.

jdalton avatar Jul 09 '14 13:07 jdalton

Howdy @jdalton! So, what's about this?

AndrewEastwood avatar Sep 26 '14 23:09 AndrewEastwood

I gotta be honest, I'm not really an active contributor to this project anymore. If any other contributor has time to pick this up, review, & merge please have at it.

jdalton avatar Sep 26 '14 23:09 jdalton

I see. Alright, let's put this on their decisions :)

AndrewEastwood avatar Sep 26 '14 23:09 AndrewEastwood