obsidian-plugin-changelogs icon indicating copy to clipboard operation
obsidian-plugin-changelogs copied to clipboard

"i" Icon disappears when trying to update

Open Archie-2021 opened this issue 3 years ago • 9 comments

when I hit the check for update button the icon disappears, and after finishing update and update button disappears it came back. it is annoying because i mostly use this icon to see the changelog at the time of updating.

Archie-2021 avatar Feb 16 '22 08:02 Archie-2021

Came here to report the same.

Can it be fixed?

Really found Plugin Changelog useful, so hope that @phibr0 you have time to look at it.

Thanks.

Ampa avatar Feb 26 '22 11:02 Ampa

I also use this plugin a lot. I have to get out of the Community plugins options in order to see the i thingy again every time I update a plugin.

AngelusDomini avatar Mar 02 '22 11:03 AngelusDomini

I have the same problem. It only appeared recently. Not sure if it's the plugin itself or some change that was made in core Obsidian. My workaround is to click on the Browse button and then to close the browse window. This causes the "i" icons to redisplay.

swehba avatar Mar 04 '22 18:03 swehba

Wanted to include additional information from my experience: The i button disappears when either clicking any of the following buttons:

  • "Check for updates" next to "Current plugins"
  • "Reload plugins" next to "Installed plugins"
  • "Update" next to any installed plugin

Essentially any button is causing the i button to be removed. Toggles do not seem to make the i button disappear.

Zachatoo avatar Mar 21 '22 04:03 Zachatoo

Essentially the plugin needs to run again (to inject the 'i' into the plugins list) whenever the plugins list refreshes. At the moment it only runs when the plugins list is first loaded.

Taking a look at Hotkey Helper, it has a lot more code hooking onto every function that causes the screen to refresh.

Sadly my javascript is not good enough to know what to borrow from the code...

https://github.com/pjeby/hotkey-helper/blob/c8a032e4c52bd9ce08cb909cec15d1ed9d0a3439/src/plugin.js#L37

Ampa avatar Mar 28 '22 22:03 Ampa

Bumping this and adding a relevant detail: pressing Update all does not cause the i icon to disappear.

firinael avatar May 04 '22 00:05 firinael

Bumping this and adding a relevant detail: pressing Update all does not cause the i icon to disappear.

what do you mean? pressing check for updates causes all the icons to disappear and they don't reappear even after pressing update all button, at least it is how it happens for me. i have to exit the plugins and reopen it to get the icon again

Archie-2021 avatar May 04 '22 04:05 Archie-2021

Pressing Check for updates does make them disappear, but pressing Update all after switching out and back into the plugins page does not.


De: Archie-2021 @.> Enviado: quarta-feira, 4 de maio de 2022 01:33 Para: phibr0/obsidian-plugin-changelogs @.> Cc: firinael @.>; Comment @.> Assunto: Re: [phibr0/obsidian-plugin-changelogs] "i" Icon disappears when trying to update (Issue #8)

Bumping this and adding a relevant detail: pressing Update all does not cause the i icon to disappear.

what do you mean? pressing check for updates causes all the icons to disappear and they don't reappear even after pressing update all button, at least it is how it happens for me. i have to exit the plugins and reopen it to get the icon again

— Reply to this email directly, view it on GitHubhttps://github.com/phibr0/obsidian-plugin-changelogs/issues/8#issuecomment-1116918903, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP7NMUK4B2QQA3WBZ24V753VIH423ANCNFSM5OQ4MJFQ. You are receiving this because you commented.Message ID: @.***>

firinael avatar May 04 '22 21:05 firinael

Pressing Check for updates does make them disappear, but pressing Update all after switching out and back into the plugins page does not. ________________________________ De: Archie-2021 @.> Enviado: quarta-feira, 4 de maio de 2022 01:33 Para: phibr0/obsidian-plugin-changelogs @.> Cc: firinael @.>; Comment @.> Assunto: Re: [phibr0/obsidian-plugin-changelogs] "i" Icon disappears when trying to update (Issue #8) Bumping this and adding a relevant detail: pressing Update all does not cause the i icon to disappear. what do you mean? pressing check for updates causes all the icons to disappear and they don't reappear even after pressing update all button, at least it is how it happens for me. i have to exit the plugins and reopen it to get the icon again — Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AP7NMUK4B2QQA3WBZ24V753VIH423ANCNFSM5OQ4MJFQ. You are receiving this because you commented.Message ID: @.***>

yes, it does, i was not noticed you mentioning the switching out from the page. it doesn't make a difference tho, I only used this plugin before applying updates to see what I am updating to right now. with this situation this plugin is useless to me

Archie-2021 avatar May 05 '22 05:05 Archie-2021